rust-lang / rust-lang/rustc_codegen_gcc
Stop formating Rvalues to get function names
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 105
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 14
Description
In https://github.com/rust-lang/rustc_codegen_gcc/blob/75a4fb996a6b175919095c11b167b5a53eb2c7aa/src/builder.rs#L367, we format an Rvalue to get a function name. This leaks memory.
We also do the same in https://github.com/rust-lang/rustc_codegen_gcc/blob/75a4fb996a6b175919095c11b167b5a53eb2c7aa/src/builder.rs#L235.
This is not a big priority(we leak the name of a function each time we call it), but nontheless something I think should be fixed at some point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/builder.rs at the referenced lines 235 and 367, where Rvalues are formatted to obtain function names. Trace how those names are used and identify an approach that avoids the reported memory leak in both locations; done means both call sites no longer format Rvalues for this purpose and the relevant codegen checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100