rust-lang / rust-lang/rustc_codegen_gcc

Use GCC unordered comparison operators

Open
#721 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement libgccjit
Dominant language
Rust
Stars
1.2k
Forks
105
Avg merge
8h 20m
Merged PRs (30d)
14

Description

I just noticed that GCC has unordered comparison operators.

It might be more efficient to use those than implementing unordered operators manually here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/builder.rs around line 1307, then read GCC's unordered comparison operators in gcc/tree.def around lines 861-870. Compare the existing manual implementation with the GCC operators and verify that the generated comparisons preserve the intended behavior and improve efficiency; the work is done when the implementation uses the appropriate GCC operators.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.