rust-lang / rust-lang/rustc_codegen_gcc

Use rustfmt more and better

Open
#670 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
1.2k
Forks
105
Avg merge
8h 20m
Merged PRs (30d)
14

Description

I see currently two issues:

  • It is not ran on some files
    • the files in tests/run
  • It doesn't seem to warn about a missing empty line around function definitions. (seems like rustfmt doesn't support this; blank_lines_lower_bound will insert lines in many other places like between statements).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the repository's Rust files and current rustfmt coverage, noting that tests/run is already covered. Then investigate rustfmt's support for blank_lines_lower_bound and the requested warnings around function definitions. Done means the intended files are covered and the blank-line requirement has a clear, validated resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.