rust-lang / rust-lang/rustc_codegen_gcc
Better removal of UI tests with errors emitted by the frontend
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 105
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 14
Description
The test tests/ui/consts/const-eval/parse_ints.rs in the file failing-ui-tests.txt even though this is not something to fix on our end.
The reason it is not removed is because the test file doesn't contain any error pattern like //@ error-pattern: and we only remove tests containing those patterns.
According to the documentation, a UI test is expected to generate a compile error by default, so perhaps we should only keep the tests with one of the pass headers:
//@ check-pass//@ build-pass//@ run-pass
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in build_system/src/test.rs around the logic linked from the issue, then compare it with tests/ui/consts/const-eval/parse_ints.rs and its entry in failing-ui-tests.txt. Check the Rust UI-test pass-header documentation to establish the intended criteria. Done means tests that do not require frontend-side fixes are removed according to those criteria, without affecting pass-header tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100