rust-lang / rust-lang/rustc_codegen_gcc

Verify if the checks for float sizes in libgccjit are necessary

Open
#487 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

libgccjit
Dominant language
Rust
Stars
1.2k
Forks
105
Avg merge
8h 20m
Merged PRs (30d)
14

Description

In https://github.com/rust-lang/gcc/pull/47, we added some checks to make sure the size of the float* types are not bigger than expected.
I'm not sure if those are necessary, so check if it is the case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing rust-lang/gcc pull request #47 and the referenced diff containing the float* size checks in libgccjit. Determine whether the checks are necessary for the supported float types and document the conclusion; completion should establish a clear decision about retaining or removing them.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.