rust-lang / rust-lang/rustc-perf

Clarify and Update Meaning of Collection Table

Open
#939 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-database
Dominant language
Rust
Stars
732
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

This issue is an extension of https://github.com/rust-lang/rustc-perf/issues/937 which aims to add more clarity to the database schema.

This issue uses the new glossary for terms. Please make sure to first refer to that glossary.

Status Quo

Currently, the collection table is used to identify a single test.

For example, given an artifact, a benchmark "hello world", the profile "debug", and the "empty" incremental cache state scenario, the collector collects many different statistics. All those statistics are identified by 1 collection. If the same test happens again, a different collection record is created.

However, we currently completely ignore this table (it is never used in any read query - only inserts).

It seems that if we run many different test iterations a different collection is created for each iteration.

Questions

Is this useful? Do we care about test results generated from different tests for the same test case and artifact combination?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the new glossary in issue #938 and the related schema discussion in issue #937. Inspect how the collection table is currently inserted and confirm that it is not used by read queries. Done means deciding whether repeated test collections are useful and documenting or implementing the agreed meaning and usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.