rust-lang / rust-lang/rustc-perf

rust-timer generated PRs include more than specific PR

Open
#832 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
732
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

For example, https://github.com/rust-lang/rust/pull/81207 included more than just the requested PR, instead also including the PRs in the "head" of the rollup. This is likely because we're reverting up to master before the rollup, but should instead revert to the parent commit of the merge commit for a specific PR in the rollup.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the rust-timer logic that prepares generated pull requests, using rust-lang/rust pull request 81207 as the reproduction case. Compare the current rollback point with the parent commit of the merge commit for the requested PR. Done means a generated PR contains only the specifically requested PR rather than additional commits from the rollup head.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.