rust-lang / rust-lang/rustc-perf

Allow annotations on the graphs

Open
#666 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-ui C-feature-request
Dominant language
Rust
Stars
733
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

When doing performance triage I currently spend a lot of time looking at improvements/regressions and seeing if they are on the same revision that I've already noted changes for. It would be extremely helpful to be able to annotate a particular revision with a vertical line and a label and have that immediately show up on all the graphs.

These annotations would then be useful to others, making it clear that someone has already looked at an improvement/regression.

Some problems that would require solving:

  • How would the data be stored?
  • Should adding a label require some kind of permissions? We wouldn't want any rando to be able to come along and add nonsense labels.
  • We'd want the ability to edit/delete labels, in the inevitable case of human error.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the graph rendering and data storage paths, then clarify annotation permissions and edit/delete behavior. Done means a revision can show a labeled vertical line consistently on all graphs, with an agreed persistence and access model.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.