rust-lang / rust-lang/rustc-perf
When graphing max-rss, we should convert to bytes.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 732
- Forks
- 189
- Avg merge
- 10h 52m
- Merged PRs (30d)
- 43
Description
Currently for e.g. 400MB max RSS the graph shows 400k (with a Kilobytes unit).
Another example is servo-script-* where the scale stops at 8M (meaning 8GB).
This confused me at first, and IMO it would be easier to read if the unit was bytes.
We don't need to change how we store the value (if that would cause issues), just how we display it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the graph rendering path for the max-rss metric and inspect how its displayed unit and scale are selected. Verify the existing stored values remain unchanged, then confirm max-rss graphs show byte units with correctly scaled values, including the 400MB and servo-script-* examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- data-visualization, performance
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100