rust-lang / rust-lang/rustc-perf

Fix running Cranelift on benchmarks with LTO

Open
#2,348 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
733
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

Cranelift cannot currently handle lto = "thin" (@bjorn3 right?), so it fails on benchmarks which use it. We should either disable LTO or (ideally) skip running Cranelift with such benchmarks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the benchmark configurations that enable lto = "thin" and the code that runs benchmarks with Cranelift. Confirm the failure, then choose whether to disable LTO or skip incompatible benchmarks; done means Cranelift benchmarks no longer fail because of ThinLTO.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.