rust-lang / rust-lang/rustc-perf
Compare page: Include current run into 30day history even if it's not merged
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 733
- Forks
- 189
- Avg merge
- 10h 52m
- Merged PRs (30d)
- 43
Description
I'm thinking of something like
I find the 30day history graph incredibly useful to quickly check how the current run compares to usual benchmark behaviour. I use it all the time during triage.
Sadly you can't do this quick check when the PR is not merged or when the run is on PR from merged rollup. At that point, you have to eyeball the comparison between the percentage number and changes in the graph, which is a bit awkward - especially since you can't see where is the parent commit in that graph by default.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Compare page implementation and the code that builds the 30-day history graph. Trace how unmerged PR runs and runs from merged rollups are excluded, then determine how the current run and its parent commit are represented. Done means the current run appears in the graph for those cases and can be compared without manual estimation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- data-visualization, performance
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100