rust-lang / rust-lang/rustc-perf

Unrolled perf run results should include a link to the relevant PR

Open
#2,225 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
733
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

When doing unrolled perf runs to investigate regressions in a rollup, it would be helpful if the automated result post would include a link to the PR whose unrolled build is being tested. That would make it easier to keep track of which results correspond to which rolled-up PR.

Currently this has to be done manually, by checking prior comments or by looking up the commit hash in the table of unrolled builds.

E.g. see https://github.com/rust-lang/rust/pull/145589#issuecomment-3203808157, where I manually added the PR link afterwards.

(No idea how feasible this is at an implementation level.)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the automated result post for unrolled perf runs and how it identifies the unrolled build or commit hash. Use the linked example comment and the table of unrolled builds as references; done means each result includes a link to the relevant rolled-up PR.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.