rust-lang / rust-lang/rustc-perf
Migrate from `cg_diff` to `cg_annotate --diff`
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 733
- Forks
- 189
- Avg merge
- 10h 52m
- Merged PRs (30d)
- 43
Description
cg_diff is deprecated now and shows this when run:
Deprecated; use `cg_annotate --diff` instead.
cg_annotate --diff also produces a better output.
rustc-perf doesn't support older versions of valgrind anyway, so we can probably require a version that supports cg_annotate --diff.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the cg_diff invocation and inspect how the Valgrind version requirement is handled. Replace the deprecated command with cg_annotate --diff, require a supporting Valgrind version if needed, and verify that the generated performance output remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100