rust-lang / rust-lang/rustc-perf
Cannot enqueue more than one build for a PR at a time
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 733
- Forks
- 189
- Avg merge
- 10h 52m
- Merged PRs (30d)
- 43
Description
When testing a regressed rollup, we may want to enqueue more than one build at a time. However, this is not possible because of a constraint on the database (found here). It's not clear to me if this constraint is actually needed or not. I can see how it might prevent certain bugs where we overly commit try builds, but in this case it is too restrictive. Can we remove this constraint?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in database/src/pool/postgres.rs at the constraint referenced in the issue and trace how builds are enqueued for a pull request. Determine whether removing it preserves the safeguards against overcommitting try builds; done means multiple builds can be enqueued for one PR without introducing those regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, rust
- Domain
- database
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100