rust-lang / rust-lang/rustc-perf

Add `-Zassert-incr-state` flag to incremental tests

Open
#1,131 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
733
Forks
189
Avg merge
10h 52m
Merged PRs (30d)
43

Description

It'd be good to add these flags to rustc-perf's incr tests once this flag is implemented, I think, FWIW.

Originally posted by @Mark-Simulacrum in https://github.com/rust-lang/rust/issues/85864#issuecomment-851587323

For examples in the rust test suite, see here and here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the incremental test definitions in rustc-perf and inspect how compiler flags are supplied. Compare them with the linked Rust test examples in link_order/auxiliary/my_lib.rs and struct_change_field_name.rs. Done means the incremental tests include -Zassert-incr-state and the relevant test run passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.