rust-lang / rust-lang/rustc-perf
Require perf-regression's to be -triaged to pass bors?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 732
- Forks
- 189
- Avg merge
- 10h 52m
- Merged PRs (30d)
- 43
Description
Following up on https://github.com/rust-lang/rust/pull/88832, it seems like a reasonable step may be to restrict bors merges to only happen after any existing perf regressions have been justified.
This might have the negative side-effect of partially discouraging perf runs, but that is hopefully unlikely. Our lack of strong follow up with PR authors + reviewers on perf justification post merge does make it harder to push for it to happen; it may be that some broader T-compiler policy work is necessary here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked pull request 88832 and the current bors merge handling for existing performance regressions. Determine the policy and implementation changes needed to require justification or triage before merging, and define done as an agreed, enforceable rule with its effects on performance runs understood.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- ci-cd, performance
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100