rust-lang / rust-lang/rust

1.99 beta crater regression: expected item after attributes

Open
#162,131 15 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-doctests A-parser I-lang-nominated I-prioritize P-lang-drag-0 regression-from-stable-to-beta S-has-bisection S-has-mcve T-lang T-rustdoc
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Reduction:

//! ```
//! #[should_panic]
//! ```

Just like #162129, the bisection points to https://github.com/rust-lang/rust/pull/159966. This used to compile in 1.98, but became an error in 1.99.

This was found many times in the crater run with various attributes or doc comments in the place of should_panic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided Rust reduction and compare its behavior between 1.98 and 1.99, then inspect the bisected change in PR #159966. Confirm that attributes or doc comments in the should_panic position are handled without the regression, and rerun the reduction against the relevant compiler tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.