rust-lang / rust-lang/rust

1.99 beta crater regression with two doc comments in one line

Open
#162,129 8 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-doctests I-prioritize needs-triage regression-from-stable-to-beta S-has-bisection S-has-mcve T-rustdoc
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

log: https://crater-reports.s3.amazonaws.com/beta-1.99-5/1.99.0-beta.1/gh/SuperInstance.renormalization-agent/log.txt
reduction:

//! ```
//! let x = 0; //! assert!(true);
//! ```

Bisection points to https://github.com/rust-lang/rust/pull/159966. This used to compile in 1.98 (and the second part was ignored entirely), but became an error in 1.99.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by compiling the minimal reduction with Rust 1.98 and 1.99, then inspect the bisection target in PR 159966 and the linked crater log. Done means determining why two doc comments on one line changed behavior and restoring the previously compiling behavior without regressing the 1.99 parser diagnostic.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.