rust-lang / rust-lang/rust

Lang/libs coordination question: okay for libs to stabilize traits with `final fn` in them?

Open
#160,394 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

disposition-merge I-lang-nominated I-lang-radar P-lang-drag-2 proposed-final-comment-period S-waiting-on-t-lang T-lang T-libs T-types
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Filing this issue to get a definitive answer on whether @rust-lang/lang has any concerns about @rust-lang/libs-api stabilizing APIs in the standard library that use final fn.

If we stabilize such an API, that commits us to keeping this mechanism. That seems fine to me, as we have an accepted RFC and we seem to have a consistent expectation of shipping/stabilizing final fn.

Tracking issue for final fn: https://github.com/rust-lang/rust/issues/131179

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with this coordination issue and the linked final fn tracking issue, #131179; no files or tests are named in the payload. Review the accepted RFC and the stated stabilization expectations, then determine whether the lang and libs-api teams have reached a definitive decision. Done means that the compatibility concern is answered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.