rust-lang / rust-lang/rust

Conditionally reenable hard_link tests on android

Open
#159,739 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-testsuite C-discussion O-android T-libs
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

#102757 disabled tests for hardlinks on android. This is unfortunate because it decreases our test-coverage, I ran into this in #159346.
Android is tier2, but we do in fact run std tests on the arm-android CI jobs.

It's not clear from the discussion on the original PR whether this was motivated by our CI or external users?
It'd be great if we could make these tests opt-{in,out} and then enable them on our CI and if necessary adjust the emulator to run with the necessary permissions to actually run the tests.

CC @pcc

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the hard_link tests disabled by #102757 and the discussion there to determine whether CI or external users motivated the change. Inspect the arm-android CI jobs and emulator configuration to see how the tests could be conditionally enabled and whether additional permissions are needed. Done means the tests run successfully on the intended Android CI jobs without breaking other environments.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, mobile-dev, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.