rust-lang / rust-lang/rust

Incorrect Generated code for Inline Assembly

Open
#156,168 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-inline-assembly A-LLVM C-bug llvm-fixed-upstream S-waiting-on-LLVM T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

The following code generates incorrect output. I would have expected the -2 to generate an error, much like mov {a}, [{a} - {b}] would. Instead the compiled output of the code below is mov {a}, [{a} + 2 * {b}] which is incorrect! The minus - is switched to a +. Also if someone is not paying attention this is extremely easy to miss since the code compiles and even runs.

use core::arch::asm;
#[unsafe(no_mangle)]
pub fn example(a: usize, b: usize) {
    unsafe {
        asm!(
            "mov {a}, [{a} - 2 * {b}]",
            a  = in(reg) a,
            b  = in(reg) b,
            options(nostack),
        )  
    };
}

You can see the example out put here on Compiler explorer:
https://godbolt.org/z/zT44bbdc5

@rustbot label +T-compiler +A-inline-assembly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the core::arch::asm example and comparing its output with the Compiler Explorer link. Trace the Rust compiler's inline-assembly handling for the - 2 * {b} expression; done means the expression is rejected as expected or the generated assembly preserves the subtraction, with a regression test covering the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.