CHECK-NOT should be written so that it cannot collide with disambiguators
Open
Nobody has claimed this yet.
A-testsuite
C-bug
T-bootstrap
T-compiler
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.2k
- PR merge metrics
- PR metrics pending
Description
Name mangling picked NtCskYmulmdsg7b as the disambiguator in symbol names, causing a test with // CHECK-NOT: mul to fail.
Originally posted by @moulins in https://github.com/rust-lang/rust/issues/151742#issuecomment-4322444304
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the test containing // CHECK-NOT: mul and reproduce the failure involving the NtCskYmulmdsg7b disambiguator. Trace how the symbol name and CHECK-NOT assertion are produced, then update the relevant test or compiler behavior so disambiguators cannot cause this collision and confirm the test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100