rust-lang / rust-lang/rust

Tracking issue for future-incompatibility lint `float_literal_f32_fallback`

Open
#154,024 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-future-incompatibility C-tracking-issue F-f16_and_f128 T-lang
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Lint on cases where {float} falls back to f32 instead of the default f64.

If there is only a single instance of a trait, like From<f32> for f32, it is used to guide type inference. That enables expressions like f32::from(0.0). With the addition of From<f16> for f32 this mechanism breaks, and the example would stop to compile.

To prevent this breakage, a workaround was introduced in the type checker. However, we'd like to remove this workaround in the future. Hence, start emitting a warning whenever this workaround is used.

This is a tracking issue for the RFC "XXX" (rust-lang/rfcs#NNN).

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

Steps
Unresolved Questions

XXX --- list all the "unresolved questions" found in the RFC to ensure they are
not forgotten

Implementation history

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Start by reading the referenced RFC and determining the implementation scope from the tracking checklist; done requires the RFC implementation plus documentation, style, and stabilization work.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.