rust-lang / rust-lang/rust

Clippy `nonminimal_bool` Crater run

Open
#153,883 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-crater S-waiting-on-review
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

This is not an issue that needs to be fixed, it was just created for a Crater experiment.
Note that this is the first Clippy Crater run. In this case for evaluating the importance of the clippy::nonminimal_bool lint, because it takes up a huge amount of processing time (~24% of linting time in syn-2.0.71).

cc https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Initial.20Clippy.20crater.20run/near/579457917

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Has.20a.20crater-like.20run.20been.20done.20for.20Clippy.3F/with/558337527

cc @Urgau

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue describes a Clippy Crater experiment evaluating the clippy::nonminimal_bool lint and its processing cost, with context in the linked Zulip discussions. Start by reading those discussions and the experiment details; this issue is complete when the Crater run has produced the intended evaluation, rather than when a code change is made.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
10/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.