Tracking issue: WASM rmake test coverage for `#[export_visibility]`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
This is a follow-up to https://github.com/rust-lang/rust/pull/151431#issuecomment-3923604898 which suggested to open a separate issue for discussing end-to-end, rmake-based wasm testing of #[export_visibility] and what would be necessary for that.
IIUC this requires:
- Enabling
"wasm"crate feature of theobjectcrate dependency insrc/tools/run-make-support/Cargo.toml- something like:object = { version = "0.37", features = ["read", "compression", "wasm"] } - Tweaking
fn dynamic_lib_prefixandfn dynamic_lib_extensioninsrc/tools/run-make-support/src/artifact_names.rsto use WASM-related values fromlibrary/std/src/sys/env_consts.rs - Ensure that
exported_dynamic_symbol_namesworks for wasm. It usesobject::File::exports, which isn't implemented yet for wasm (as pointed out in https://github.com/rust-lang/rust/pull/151431#issuecomment-3919390374)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/tools/run-make-support/Cargo.toml, then inspect dynamic_lib_prefix and dynamic_lib_extension in src/tools/run-make-support/src/artifact_names.rs. Read how exported_dynamic_symbol_names uses object::File::exports and the linked discussions about WASM support. Done means the required end-to-end, rmake-based WASM coverage for #[export_visibility] is defined and the listed support gaps are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, wasm
- Domain
- build-system, compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100