rust-lang / rust-lang/rust

Support `if let` guards in `matches!()` and `assert_matches!()`

Open
#152,313 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-macros A-patterns C-feature-request T-libs
Dominant language
Rust
Stars
119k
Forks
16.2k
PR merge metrics
PR metrics pending

Description

Once https://github.com/rust-lang/rust/pull/141295 (stabilizing if_let_guards) is merged, we should probably support if let guards in matches!() and assert_matches!().

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request 141295 and locating the definitions and tests for matches!() and assert_matches!(). Confirm how the stabilized if let guard syntax should be accepted, then add support and tests demonstrating both macros handle it correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.