rust-lang / rust-lang/rust

BinaryHeap integer overflow with ZST?

Open
#149,448 1 comment 0 reactions 1 assignee View on GitHub

@Saphereye is already working on this.

Since Dec 4, 2025.

A-collections A-ZST C-bug T-libs
Dominant language
Rust
Stars
119k
Forks
16.1k
PR metrics pending

Description

I found this comment in the standard library, indicating that BinaryHeap can have an integer overflow with a large collection of ZSTs. This should probably be fixed.

https://github.com/rust-lang/rust/blob/467250ddb25a93315a8dee02dd6cc1e398be46ff/library/alloc/src/collections/binary_heap/mod.rs#L788-L789

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.