rust-lang / rust-lang/rust

compiletest: Add a variant of `{{build-base}}` that points to the current test's build subdirectory

Open
#147,216 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest C-enhancement T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Several of the existing tests that use {{build-base}} would be better off using a test-specific output subdirectory (or an automatically-cleared scratch directory), rather than the “root” output directory shared by all tests in a test suite.

Unfortunately, this is currently hard to accomplish because parse_name_value_directive doesn't have access to any test-specific data structures, only the &Config shared by all tests in the suite.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing compiletest's parse_name_value_directive and the shared Config it currently receives. Determine how a directive variant can identify the current test's build subdirectory or an automatically-cleared scratch directory, then verify that tests using it no longer share the suite's root output directory.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.