rust-lang / rust-lang/rust

Very slow `EverInitializedPlaces` analysis on async fn with many awaits

Open
#144,635 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-borrow-checker C-bug I-compiletime T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

I have a tool that generates code and for debugging purposes that has a function that summarizes the state of the whole thing. So that's an async function with potentially a lot of awaits.

I posted in this issue first: https://github.com/rust-lang/rust/issues/138828#issuecomment-3132174620
But then was advised to open a new issue. And after that I was able to reduce it much further.

I tried this code:
https://gist.github.com/diondokter/ec4659f8b80b3f92643138606df5fa93#file-repro-rs
(Very long so in a gist)
rustc +nightly compile_time_explosion.rs --edition 2024 -Ztime-passes

I expected to see this happen: relatively normal compile times

What happens instead is that this takes 21 seconds.

...
time:   0.000; rss:   33MB ->   32MB (   -1MB)  drop_ast
time:   0.000; rss:   32MB ->   32MB (   +0MB)  looking_for_entry_point
time:   0.000; rss:   32MB ->   32MB (   +0MB)  looking_for_derive_registrar
time:   0.000; rss:   33MB ->   33MB (   +0MB)  unused_lib_feature_checking
time:   0.003; rss:   32MB ->   33MB (   +1MB)  misc_checking_1
time:  21.327; rss:   33MB ->   93MB (  +60MB)  coherence_checking
time:   0.000; rss:   93MB ->   93MB (   +0MB)  emit_ast_lowering_delayed_lints
time:  21.328; rss:   33MB ->   93MB (  +60MB)  type_check_crate
time:   0.506; rss:   93MB ->  100MB (   +7MB)  MIR_borrow_checking
time:   0.000; rss:  100MB ->  100MB (   +0MB)  layout_testing
time:   0.000; rss:  100MB ->  100MB (   +0MB)  abi_testing
time:   0.000; rss:  100MB ->  100MB (   +0MB)  crate_lints
time:   0.003; rss:  100MB ->  101MB (   +0MB)  module_lints
...

The coherence checking also seems to be quadratic or something.
This is the compile time changes in my tool:

num awaits num awaits % time time %
1000 100% 59s 100%
1100 110% 75s 127%
1200 120% 99s 170%

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reduced repro in the linked compile_time_explosion.rs gist and run rustc +nightly compile_time_explosion.rs --edition 2024 -Ztime-passes. Compare the reported scaling as the number of awaits increases, focusing first on the coherence_checking and type_check_crate phases. Done means identifying and addressing the cause of the excessive compile time and confirming improved scaling on the repro.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.