rust-lang / rust-lang/rust

Need test coverage for attr edge-cases (ambiguity, ignored positions, etc)

Open
#143,911 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

A-attributes A-testsuite C-bug T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

We have a variety of edge-cases involving attributes that are either simply untested or under-tested, and certainly not tested for every attribute where it is relevant. As most attributes are a series of special-cases (though less so now) they each need testing.

A key issue is that they have interactions with proc-macro attributes and such.

We are currently allowing this to happen and not blocking PRs on fixes in this area because we already have legacy problems in this lack of coverage and we are in the middle of a migration.

This came up in

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.