rust-lang / rust-lang/rust

Clean up remnants of #110395

Open
#143,871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-testsuite C-cleanup F-const_trait_impl T-compiler T-libs
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

#110395 left us with many test cases that have been disabled because the standard library traits that used to be const are not anymore.

For these cases we should:

  • Find out if they can be written without depending on the traits or impls being const. If they can, rewrite them and re-enable them.
  • If they can't be written without depending on impl const or const traits, constify the relevant traits and impls where possible. Re-enable them

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the disabled test cases identified by the linked repository search and review the changes from #110395. For each case, determine whether it can avoid const traits or const implementations, or whether the relevant trait or implementation can be constified. Done means applicable cases are re-enabled and the remaining cases have the required const support.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.