rust-lang / rust-lang/rust

LLVM CFI integration being undocumented complicates further codegen dev

Open
#143,751 4 comments 1 reaction 1 assignee View on GitHub

@rcvalle is already working on this.

Since Jul 14, 2025.

A-control-flow-integrity PG-exploit-mitigations T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

When https://github.com/rust-lang/rust/pull/105452 and related PRs added a bunch of parameters to things like BuilderMethods::call, it did not include explanations of what those parameters were for. Namely, that they were for CFI tracking and that they were not relevant to actual ABI handling.

The knowledge exists in the heads of Rust contributors, of course, so we can just talk to each other... except for how it is in the heads of Rust contributors who are very busy because they have a lot of different things they have to attend to because they're the only one who knows the thing.

I would like to see these just-for-CFI changes documented and ideally cleaned up so we are no longer passing ambiguous details around which are secretly-only-advisory-except-if-you-are-doing-CFI-related-codegen-in-which-case-it-is-critical.

cc @rcvalle

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.