rust-lang / rust-lang/rust

cargo tests seems to not run by default on `./x test --stage 2`

Open
#141,686 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-testsuite C-bug T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.2k
PR merge metrics
PR metrics pending

Description

It seems surprising that we don't yet run cargo's tests in CI for hosts by default (as part of ./x test) on stage 2

$ ./x test --dry-run --stage=2 | grep cargo
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.02s
Documenting stage2 cargo (x86_64-unknown-linux-gnu)
Doc path: /home/joe/repos/rust/build/tmp-dry-run/x86_64-unknown-linux-> gnu/doc/cargo/index.html
Building tool cargo (stage1 -> stage2, x86_64-unknown-linux-gnu)
Build completed successfully in 0:00:00

🤔

Yeah, e.g.

https://github.com/rust-lang/rust/blob/642e49bfed2481e54e252732be20d3c24cbec9e8/src/ci/github-actions/jobs.yml#L513-L516

That seems weird

Originally posted by @jieyouxu in https://github.com/rust-lang/rust/issues/141656#issuecomment-2913370292

I haven't looked into this yet, opening an issue to track.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running ./x test --dry-run --stage=2 and inspect the cargo-related output. Compare the relevant CI configuration in src/ci/github-actions/jobs.yml around lines 513-516; done means stage 2 host testing runs Cargo's tests by default and the CI job reflects that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.