Tracking Issue for nvptx_target_feature
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
This is a tracking issue for the NVPTX part of #44839 (RFC 2045; rust-lang/rfcs#2045).
The feature gate for the issue is #![feature(nvptx_target_feature)].
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.
Steps
- Implementation https://github.com/rust-lang/rust/pull/138689
- Stabilization PR (see instructions on rustc-dev-guide)
Unresolved Questions
- Should
ptx*andsm_*be target features or should they be target modifiers; cf. https://internals.rust-lang.org/t/why-are-forbidden-target-features-disallowed-in-cfg-target-feature/22944/4.- They are exposed as LLVM features, but LLVM does not currently intend these features to be applied as function attributes. As such, we'd prefer that it be erroneous to use
#[target_feature(enable = "ptx80")]. - This relates to how
core::arch::nvptxis compiled. If we use#[cfg(target_feature = "ptx80")]for relevant intrinsics, then the user must build their crates using-Zbuild-std=corewith appropriateRUSTFLAGS.
- They are exposed as LLVM features, but LLVM does not currently intend these features to be applied as function attributes. As such, we'd prefer that it be erroneous to use
- When target features are activated using
-Ctarget-feature=+ptx80or#[target_feature(enable = "ptx80")], all the implied features are also added to LLVM functions. LLVM doesn't officially support that (though it seems to work with LLVM-20), so it would be preferable to only pass the highest level LLVM feature and ensure that is applied at crate/PTX module granularity. Ideally this would be done in a way that would also suppress the redundant warnings.
Implementation history
@rustbot label +O-NVPTX +A-target-feature
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the implementation PR rust-lang/rust#138689 and the linked RFC 2045 material, then review the stabilization guide. The tracking issue is complete when implementation and stabilization are resolved, including decisions on target features versus modifiers and how implied NVPTX features are applied.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100