rust-lang / rust-lang/rust

`x test tidy` can be faster

Open
#141,074 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-enhancement T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Right now, x test tidy includes two additional checks besides tidy itself: auto-completions and rustfmt check. Currently, they run sequentially, but running them concurrently could speed things up; potentially saving around one second depending on the machine specs. It's a quite popular and frequently used command, so it's worth making it faster.

Somewhat related: https://github.com/rust-lang/rust/issues/141073

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the implementation of x test tidy and locating the auto-completions and rustfmt checks. Confirm their current sequential behavior, then measure the command before and after making the checks concurrent; done means the checks still run correctly and the command is faster.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.