Test for #7663 doesn't test anything (?)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
This is a similar story to #140765. Basically tests/ui/issues/issue-7663.rs doesn't test anything as the glob imports were removed from the file and there's no duplicated import for p on either case.
I think the test should no longer be run-pass and instead it should test that:
- Importing both
pitems with glob imports fails - Importing both
pitems with non-glob imports fails - Importing one
pwith a glob import and anotherpwith a non-glob import is ok.
I'll create a PR with a fix if this is correct.
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tests/ui/issues/issue-7663.rs and compare it with the behavior described in issue #7663. First inspect the existing imports and test mode, then adjust the test coverage for the three glob and non-glob import combinations described here. Done means the conflicting cases fail, the mixed case succeeds, and the test is no longer run-pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100