`run-make` test failures when building rust-with rpath disabled
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Similar to #140299, we're seeing some run-make tests failing to run due to missing librustc_driver when building with rpath disabled:
<build-dir>/x86_64-unknown-linux-gnu/stage1/bin/rustc: error while loading shared libraries: librustc_driver-b8b100cea390592b.so: cannot open shared object file: No such file or directory
Tests that fail:
* [run-make] tests/run-make/broken-pipe-no-ice
* [run-make] tests/run-make/compiler-builtins
* [run-make] tests/run-make/rustc-crates-on-stable
The root cause is that these tests either:
- Create a
Command::new(env_var("RUSTC"))instead using therustc()wrapper provided by run-make-support, or - Use the
cargo()wrapper fromrun-make-support, which doesn't set the runtime library path (e.g. LD_LIBRARY_PATH) likerustc()does.
To reproduce in a clean tree:
./config --disable-rpath
python x.py test --force-rerun tests/run-make/{broken-pipe-no-ice,compiler-builtins,rustc-crates-on-stable}
Originally reproduced on beta (973ec11f61b), still happens on latest master (71b68da1bd9).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/run-make/broken-pipe-no-ice, tests/run-make/compiler-builtins, and tests/run-make/rustc-crates-on-stable, then inspect the run-make-support rustc() and cargo() wrappers. Reproduce with --disable-rpath using the x.py command in the issue and compare how each test launches Rust tools. Done means all three tests run successfully with rpath disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100