rust-lang / rust-lang/rust

Suboptimal diagnostic E0599 on `impl AsRef<T>`

Open
#140,178 1 comment 0 reactions 1 assignee View on GitHub

@Kivooeo is already working on this.

Since Apr 23, 2025.

A-diagnostics T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Code
pub fn foo(path: impl AsRef<std::path::Path>) {
    let _ = path.join("bar");
}
Current output
error[E0599]: no method named `join` found for type parameter `impl AsRef<std::path::Path>` in the current scope
 --> src/lib.rs:2:18
  |
1 | pub fn foo(path: impl AsRef<std::path::Path>) {
  |                  --------------------------- method `join` not found for this type parameter
2 |     let _ = path.join("bar");
  |                  ^^^^ method not found in `impl AsRef<std::path::Path>`

For more information about this error, try `rustc --explain E0599`.
Desired output
It should suggest `path.as_ref().join(..)` (add in the `.as_ref()`) to make it visible.
Rationale and extra context

I was helping someone else new to Rust, and I suggested that they use Path::join() to append to a path. They initially tried doing that, but then it didn't work because they had the code like the one in the snippet and impl AsRef<Path> doesn't have a .join() method. Iteratively trying things and fixing them on their own, with hints from the rust compiler, they eventually landed on this worse code that does compile:

pub fn foo(path: impl AsRef<std::path::Path> + std::fmt::Display) {
    let _ = format!("{path}/bar");
}

I think they would have found their way to the correct solution if there was any sort of hint that the problem was that they needed to add a .as_ref() call.

More generally, I think this would be good for any impl AsRef<T>, if someone tries to use a method/field on T itself (maybe excluding cases where you either have impl AsRef<T> + AsRef<U> or impl<U: AsRef<T>> SomeTrait for U, I think these diagnostics might not be as helpful in edge-cases like those).

Other cases

Rust Version
the current nightly as hosted on play.rust-lang.org
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.