compiletest: consider rejecting conditional test execution directives being used together with unconditional test disabling directives
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Remark: useless/misleading
//@ run-passin a few aux files that are//@ ignore-test(//@ ignore-auxiliary)
Originally posted by @jieyouxu in https://github.com/rust-lang/rust/pull/139967#discussion_r2048970713
Consider rejecting combination of
- Conditional test execution directives (e.g.
//@ ignore-*), with - Unconditional test execution directives (e.g.
//@ ignore-test),
Since the unconditional test ignore will "absorb" conditional ones. Probably do this after reworking directive handling.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading compiletest's directive handling, especially how conditional directives such as //@ ignore-* interact with unconditional directives such as //@ ignore-test and //@ ignore-auxiliary. Done should include rejecting combinations where an unconditional directive absorbs a conditional one, while accounting for the planned directive-handling rework.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100