rust-lang / rust-lang/rust

Audit unsafe usages in compiletest

Open
#139,616 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest C-bug T-bootstrap T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

compiletest has some unsafe usages in raise_fd_limit.rs and read2.rs which have no safety comments (esp. those that calls out to libc). It would be good to audit their usages and justify why their usages are sound.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading compiletest's raise_fd_limit.rs and read2.rs, then locate each unsafe usage, especially calls involving libc. Audit the surrounding assumptions and document why each usage is sound with safety comments; done means the identified unsafe usages have clear justifications.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.