rust-lang / rust-lang/rust

Refactor `contracts` attribute expansion as AST macro

Open
#139,304 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-cleanup F-contracts T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Currently it is using token streams to extend macros, which causes some problems, as discussed in #137129 and #138852. Maybe we should refactor it to AST macros, which can do more accurate analysis.

cc @Noratrieb

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussions in #137129 and #138852, then compare the current token-stream approach for contracts attribute expansion with the proposed AST macro approach. Done means the expansion is refactored to AST macros and the problems motivating this issue are addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.