rust-lang / rust-lang/rust

Wrong symbols are referenced for raw-dylib on i686-pc-windows-gnu

Open
#138,963 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-linkage C-bug F-raw_dylib O-windows-gnu O-x86_32 T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

The following code:

#[no_mangle]
pub extern "C" fn foo() {
    unsafe {
        windows_sys::Win32::System::Com::CoInitializeEx(std::ptr::null(), 0);
    }
}

With the following dependency:

windows-sys = { version = "0.59", features=["Win32_System_Com"] }

Also add the following to Cargo.toml:

[lib]
crate-type = ["staticlib"]

Building with RUSTFLAGS=--cfg=windows_raw_dylib cargo build --target i686-pc-windows-gnu (enabling raw-dylibs) produces a .a file that contains an ole32.dll import with the following references (as per llvm-readobj --symbols):

  Symbol {
    Name: CoInitializeEx
    Value: 0
    Section: .text (1)
    BaseType: Null (0x0)
    ComplexType: Null (0x0)
    StorageClass: External (0x2)
    AuxSymbolCount: 0
  }
  Symbol {
    Name: __imp_CoInitializeEx
    Value: 0
    Section: .idata$5 (5)
    BaseType: Null (0x0)
    ComplexType: Null (0x0)
    StorageClass: External (0x2)
    AuxSymbolCount: 0
  }

The real libole32.a from mingw contains:

  Symbol {
    Name: _CoInitializeEx@8
    Value: 0
    Section: .text (1)
    BaseType: Null (0x0)
    ComplexType: Null (0x0)
    StorageClass: External (0x2)
    AuxSymbolCount: 0
  }
  Symbol {
    Name: __imp__CoInitializeEx@8
    Value: 0
    Section: .idata$5 (5)
    BaseType: Null (0x0)
    ComplexType: Null (0x0)
    StorageClass: External (0x2)
    AuxSymbolCount: 0
  }

IOW, the symbol is decorated in the real library, but is not in the raw-dylib. This can cause problems downstream e.g. when linking with delayload.

See #130586 for a similar problem on i686-pc-windows-msvc that was fixed in 1.84.0.

Cc: @dpaoliello @kennykerr

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce with the provided Rust example, Cargo.toml crate type, target, RUSTFLAGS, and cargo build command. Inspect the generated .a file with llvm-readobj --symbols and compare its ole32.dll symbols with the real libole32.a; use issue #130586 and its 1.84.0 fix as the first related reference. Done means the i686 raw-dylib symbols match the decorated references expected by the MinGW library.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.