rust-lang / rust-lang/rust

Some sanitizers should be target modifiers

Open
#138,453 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-sanitizers C-bug F-target_modifiers T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer

For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier. Same applies to #138311 when it lands.

The shadow-call-stack sanitizer is currently being considered as a target modifier for simplicity. However, there are cases where it does not need to be a target modifier.

Please see the target modifiers tracking issue for more details. See also the Tracking Issue for stabilizing the sanitizers.

cc @rcvalle @azhogin @maurer
@rustbot label F-target_modifiers A-sanitizers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the target modifiers tracking issue #136966 and the sanitizer stabilization issue #123615, then review the related work in #138311. Clarify the intended treatment of shadow-call-stack before implementing the sanitizer exceptions and kCFI helper flag as target modifiers.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.