rust-lang / rust-lang/rust

Investigate why repr-128-dwarf doesn't fail in CI test jobs

Open
#138,334 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest A-debuginfo A-download-rustc A-LLVM A-test-infra C-bug T-bootstrap T-infra
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

I'm not sure why this passes in CI though. Surely we have some jobs that enable LLVM assertions? Seems like not, test jobs typically don't enable LLVM assertions due to slowness.

That doesn't sound right. LLVM assertions are supposed to be enabled for all test jobs, except those marked NO_LLVM_ASSERTIONS, which is only the apple ones.

Originally posted by @nikic in #138254

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the CI test jobs and how LLVM assertions are enabled or disabled, especially the NO_LLVM_ASSERTIONS exception for Apple jobs. Reproduce the repr-128-dwarf behavior in the relevant CI configuration and determine why the expected failure is not occurring. Done means the cause is identified and the affected test jobs behave as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.