rust-lang / rust-lang/rust

non-obvious choices in std IPv6 test creation

Open
#138,328 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-io A-testsuite C-bug T-libs
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

re: https://github.com/rust-lang/rust/blob/9fb94b32df38073bf63d009df77ed10cb1c989d0/library/std/src/net/udp/tests.rs

We make a bunch of devices with a scope_id of 0, but the value of 0 is a reserved scope_id. I believe it's usually ignored or treated as equivalent to "eh whatever", but we probably should be making them with scope_id: 1, i.e. "entirely local to here". This prompted https://github.com/rust-lang/rust/pull/137967 because AIX helpfully fixes the value of scope_id to the one it interprets it as: 1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with library/std/src/net/udp/tests.rs at the IPv6 test setup described in the issue. Review the devices created with scope_id: 0, update the relevant values to 1, and run the associated Rust standard-library networking tests to confirm the expected behavior, including the AIX-related case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.