Bootstrap vendoring requires `rustc-perf` submodule (unconditionally?)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
[...] it seems this patch has broken our Rust mirror for Fuchsia. We've had to exclude
rustc-perffrom our local mirror since it has a pretty complicated licensing story. Rust previously built fine for us since we weren't running the performance tests, but with this patch we're now getting this error:submodule src/tools/rustc-perf does not appear to be checked out, but it is required for this step. Consider setting `build.submodules = true` or manually initializing the submodules.Is there any way we could work around this, or add a flag where we could skip this check?
Originally posted by @erickt in https://github.com/rust-lang/rust/issues/137020#issuecomment-2666960366
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the bootstrap vendoring path that requires the src/tools/rustc-perf submodule and how the build.submodules setting is handled. Reproduce the failure with rustc-perf absent; done means a build can skip the submodule when performance tests are not being run without breaking those tests when enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100