rust-lang / rust-lang/rust

compiletest: investigate if compare-mode nits are still relevant

Open
#136,513 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest A-compiletest-compare-modes C-cleanup T-bootstrap T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

also, I don't know if this is exactly relevant to this particular PR, but during my experimentation: When I created an empty augmented-assignments.nll.stderr file, I expected to see a diff that just showed all plusses. (I.e., a diff against an empty file)

But instead it seems like if the revision file is empty, then it falls back on the base file augmented-assignments.stderr, in this particular case...

  • (From skimming the PR, I'm not even clear on how we are observing such a semantics... but nonetheless, it is what I am seeing.)

(I don't know whether other people think that fall back behavior for empty files is more intutive... it wasn't intuitive for me, since I'm the kind of person who will just do touch augmented-assignments.nll.stderr and then run the tool to see what the content is that I need to add.)

Originally posted by @pnkfelix in https://github.com/rust-lang/rust/issues/49293#issuecomment-379049906

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating compiletest's compare-mode handling and the augmented-assignments.nll.stderr and augmented-assignments.stderr test files. Reproduce the behavior with an empty revision file, then determine the intended result and capture the expected behavior in the relevant test or issue documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.