We should build ALL Rust code in this repo in CI
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
We should build ALL Rust code in this repo when we do in CI. Including subtrees. This is needed to ensure that contributors will not occasionally break anything, especially when doing tree-wide changes../x test
For example, in https://github.com/rust-lang/rust/pull/134420 a contributor replaced tree-wide &PathBuf with &Path. Unfortunately, he broke ./x perf. This was not noticed, because src/tools/rustc-perf-wrapper is not built during ./x test
So, please, build everything in ./x test
I add "contributor roadblock", because I think this is minor contributor roadblock.
@rustbot label A-contributor-roadblock C-enhancement -C-bug
HEAD
fd19773d2f8a070dc03f0072f9bc41a65fd04fed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how ./x test is invoked in CI and how subtrees such as src/tools/rustc-perf-wrapper are handled. Determine the scope of Rust code that the current CI path omits, then verify that the completed CI run builds all such subtrees without breaking existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100