new build_helper::compiletest module for safer invocations of compiletest by bootstrap
Open
@lolbinarycat is already working on this.
Since Jan 17, 2025.
A-compiletest
C-cleanup
T-bootstrap
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
currently bootstrap just uses strings to represent various compiletest arguments, such as mode.
obviously it would be better to use enums for these, as they are much less vulnerable to typos.
compiletest already has enum definitions for these (in common.rs), and the two already have a shared dependency (build_helper), and build_helper already has access to serde.
i would be willing to work on this refactor, if people think it would be a good idea.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.