rust-lang / rust-lang/rust

running `rustdoc-js-std` tests does not rebuild rustdoc even if it is dirty

Open
#135,590 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-testsuite C-bug T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

reproduction steps:

  1. ./x test -v tests/rustdoc-js-std/return-based-sort.js (or any other unit test in the folder, probably)
  2. make a change to search.js (one that impacts the result of the test will make it more obvious)
  3. ./x test -v tests/rustdoc-js-std/return-based-sort.js (again)

rustdoc will not get rebuilt.

i've run into this a few times before but i only now figured out what was happening (i think?).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce with ./x test -v tests/rustdoc-js-std/return-based-sort.js, then modify search.js and run the same test again. Trace how this test is selected and how rustdoc rebuild decisions are made. Done means the second run rebuilds rustdoc and reflects the search.js change in the test result.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.